Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mouse): middle or right clicks creating selection #1372

Merged
merged 1 commit into from
May 3, 2022

Conversation

tlinford
Copy link
Contributor

@tlinford tlinford commented May 3, 2022

fix #1371

@tlinford tlinford temporarily deployed to cachix May 3, 2022 10:44 Inactive
@tlinford
Copy link
Contributor Author

tlinford commented May 3, 2022

@raphCode would you mind giving this a spin to see if it doesn't cause other problems?

@raphCode
Copy link
Contributor

raphCode commented May 3, 2022

I couldn't find any mouse-related problem in a quick test drive!
Nice :)

@tlinford
Copy link
Contributor Author

tlinford commented May 3, 2022

I couldn't find any mouse-related problem in a quick test drive! Nice :)

thanks!

not sure what is wrong with the e2e tests, it's failing on the Install cargo-make step with:
warning: error: unable to download 'https://api.github.com/repos/NixOS/nixpkgs/tarball/b283b64580d1872333a99af2b4cef91bb84580cf': HTTP error 500 ('').

@raphCode
Copy link
Contributor

raphCode commented May 3, 2022

not sure what is wrong with the e2e tests

I also just noticed similar problems on a different PR, so it seems the CI has a hiccup atm.

@tlinford tlinford merged commit a62743a into main May 3, 2022
@tlinford tlinford deleted the fix-middle-or-right-click-selection branch May 3, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle or right click creates weird persistent selections
2 participants